From 28377f0ef2a45c135456da371e93d2b065ff614b Mon Sep 17 00:00:00 2001 From: gered Date: Sat, 14 Feb 2015 20:27:45 -0500 Subject: [PATCH] double negatives are bad --- src/clj_webtoolbox/routes/checked.clj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/clj_webtoolbox/routes/checked.clj b/src/clj_webtoolbox/routes/checked.clj index c0f5339..edada7f 100644 --- a/src/clj_webtoolbox/routes/checked.clj +++ b/src/clj_webtoolbox/routes/checked.clj @@ -11,13 +11,13 @@ [clj-webtoolbox.routes.core :refer [destructure-route-bindings]] [clj-webtoolbox.utils :refer [pred-> request?]])) -(defn no-errors? [request] - (not (seq (:validation-errors request)))) +(defn has-errors? [request] + (seq (:validation-errors request))) (defmacro threaded-checks [request checks fail-response] - `(let [result# (pred-> ~request no-errors? ~@checks)] + `(let [result# (pred-> ~request #(not (has-errors? %)) ~@checks)] (if (and (request? result#) - (not (no-errors? result#))) + (has-errors? result#)) (if (response? ~fail-response) ~fail-response (~fail-response result#))