From 4d4f75a8a8a349e73dfd85ec0737ad42f5171eb0 Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Tue, 7 May 2024 10:35:44 -0700 Subject: [PATCH] Revert "fix golangci workflow missing gofmt and goimports (#4190)" This reverts commit 04f971c84be907b90edfdd409f84b892a3586705. --- .github/workflows/test.yaml | 2 +- .golangci.yaml | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 313d11cb..9a2544b8 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -269,7 +269,7 @@ jobs: mkdir -p llm/build/darwin/$ARCH/stub/bin touch llm/build/darwin/$ARCH/stub/bin/ollama_llama_server if: ${{ startsWith(matrix.os, 'macos-') }} - - uses: golangci/golangci-lint-action@v5 + - uses: golangci/golangci-lint-action@v4 with: args: --timeout 8m0s -v test: diff --git a/.golangci.yaml b/.golangci.yaml index ba8e81c7..7dec49de 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -9,8 +9,9 @@ linters: - contextcheck - exportloopref - gocheckcompilerdirectives - - gofmt - - goimports + # FIXME: for some reason this errors on windows + # - gofmt + # - goimports - misspell - nilerr - unused