From e03637176d90cc5e298e13dfd5e583b2989b3aee Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Thu, 9 May 2024 17:44:34 -0700 Subject: [PATCH] fix(routes): skip bad manifests --- server/routes.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/server/routes.go b/server/routes.go index 130423b7..ec9f0e76 100644 --- a/server/routes.go +++ b/server/routes.go @@ -735,24 +735,27 @@ func (s *Server) ListModelsHandler(c *gin.Context) { n := model.ParseNameFromFilepath(rel) if !n.IsValid() { - slog.Info("invalid model filepath", "path", rel) + slog.Warn("bad manifest filepath", "path", rel) return nil } m, err := ParseNamedManifest(n) if err != nil { - return err + slog.Warn("bad manifest", "name", n, "error", err) + return nil } f, err := m.Config.Open() if err != nil { - return err + slog.Warn("bad manifest config filepath", "name", n, "error", err) + return nil } defer f.Close() var c ConfigV2 if err := json.NewDecoder(f).Decode(&c); err != nil { - return err + slog.Warn("bad manifest config", "name", n, "error", err) + return nil } // tag should never be masked