wrap api routes with exception handler middleware

src/mtgcoll/middleware.clj

@@ -1,5 +1,6 @@
 (ns mtgcoll.middleware
   (:require
+    [clojure.tools.logging :as log]
     [webtools.response :as response]
     [mtgcoll.auth :as auth]))
 
@@ -10,4 +11,15 @@
             (get-in request [:session :user]))
       (handler request)
       (-> (response/content "unauthorized")
-          (response/status 401)))))
+          (response/status 401)))))
+
+(defn wrap-api-exceptions
+  [handler]
+  (fn [request]
+    (try
+      (handler request)
+      (catch Exception ex
+        (log/error ex "Unhandled exception.")
+        (-> (response/json {:status  "error"
+                            :message (.getMessage ex)})
+            (response/status 500))))))

src/mtgcoll/routes/auth.clj

@@ -3,30 +3,37 @@
     [clojure.tools.logging :as log]
     [compojure.core :refer [routes GET POST]]
     [webtools.response :as response]
+    [webtools.routes.core :refer [wrap-middleware]]
     [webtools.session :as session]
+    [mtgcoll.middleware :refer [wrap-api-exceptions wrap-authenticated]]
     [mtgcoll.auth :as auth]))
 
 (def auth-routes
-  (routes
+  (wrap-middleware
-    (POST "/login" [username password :as request]
+    (routes
-      (if-let [user (auth/validate-credentials username password)]
+      (POST "/login" [username password :as request]
-        (do
+        (if-let [user (auth/validate-credentials username password)]
-          (log/info username " logged in.")
+          (do
-          (-> (response/json user)
+            (log/info username " logged in.")
-              (session/set-from-request request)
+            (-> (response/json user)
-              (session/assoc :user user)))
+                (session/set-from-request request)
-        (do
+                (session/assoc :user user)))
-          (log/warn "Unsuccessful login attempt by: " username)
+          (do
-          (-> (response/content "bad username/password")
+            (log/warn "Unsuccessful login attempt by: " username)
-              (response/status 401)))))
+            (-> (response/json {:status  "unauthorized"
+                                :message "bad username/password"})
+                (response/status 401)))))
 
-    (POST "/logout" request
+      (POST "/logout" request
-      (if-let [user (get-in request [:session :user])]
+        (if-let [user (get-in request [:session :user])]
-        (do
+          (do
-          (log/info (:username user) " logged out.")
+            (log/info (:username user) " logged out.")
-          (-> (response/content "ok")
+            (-> (response/content "ok")
-              (session/set-from-request request)
+                (session/set-from-request request)
-              (session/dissoc :user)))
+                (session/dissoc :user)))
-        (do
+          (do
-          (-> (response/content "not logged in")
+            (-> (response/json {:status  "error"
-              (response/status 400)))))))
+                                :message "not logged in"})
+                (response/status 400))))))
+
+    (wrap-api-exceptions)))

src/mtgcoll/routes/collection.clj

@@ -3,7 +3,7 @@
     [compojure.core :refer [routes GET POST]]
     [webtools.response :as response]
     [webtools.routes.core :refer [wrap-middleware]]
-    [mtgcoll.middleware :refer [wrap-authenticated]]
+    [mtgcoll.middleware :refer [wrap-api-exceptions wrap-authenticated]]
     [mtgcoll.models.collection :as collection]))
 
 (def collection-routes
@@ -23,4 +23,6 @@
         (let [username (get-in request [:session :user :username])
               result   (collection/copy-list! source-list-id destination-list-id username)]
           (response/json {:status "ok"}))))
+
+    (wrap-api-exceptions)
     (wrap-authenticated)))

src/mtgcoll/routes/lists.clj

@@ -3,7 +3,7 @@
     [compojure.core :refer [routes GET POST]]
     [webtools.response :as response]
     [webtools.routes.core :refer [wrap-middleware]]
-    [mtgcoll.middleware :refer [wrap-authenticated]]
+    [mtgcoll.middleware :refer [wrap-api-exceptions wrap-authenticated]]
     [mtgcoll.models.lists :as lists]))
 
 (def list-routes
@@ -31,4 +31,5 @@
         (lists/update-list-visibility! list-id public?)
         (response/json {:status "ok"})))
 
+    (wrap-api-exceptions)
     (wrap-authenticated)))