From 59185abfd98ba130436bd1b0c562645cfc97d71e Mon Sep 17 00:00:00 2001 From: Luc Georges Date: Thu, 9 Nov 2023 12:00:39 +0100 Subject: [PATCH] feat!: make API camelCase (#46) API had inconsistencies in case --- crates/llm-ls/src/main.rs | 4 ++++ crates/testbed/repositories-ci.yaml | 6 +++--- crates/testbed/repositories.yaml | 6 +++--- crates/testbed/src/types.rs | 2 ++ 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/crates/llm-ls/src/main.rs b/crates/llm-ls/src/main.rs index 17c2149..20eba32 100644 --- a/crates/llm-ls/src/main.rs +++ b/crates/llm-ls/src/main.rs @@ -93,6 +93,7 @@ enum TokenizerConfig { } #[derive(Clone, Debug, Deserialize, Serialize)] +#[serde(rename_all = "camelCase")] struct RequestParams { max_new_tokens: u32, temperature: f32, @@ -208,6 +209,7 @@ where } #[derive(Debug, Deserialize, Serialize)] +#[serde(rename_all = "camelCase")] struct AcceptedCompletion { request_id: Uuid, accepted_completion: u32, @@ -215,12 +217,14 @@ struct AcceptedCompletion { } #[derive(Debug, Deserialize, Serialize)] +#[serde(rename_all = "camelCase")] struct RejectedCompletion { request_id: Uuid, shown_completions: Vec, } #[derive(Debug, Deserialize, Serialize)] +#[serde(rename_all = "camelCase")] struct CompletionParams { #[serde(flatten)] text_document_position: TextDocumentPositionParams, diff --git a/crates/testbed/repositories-ci.yaml b/crates/testbed/repositories-ci.yaml index 4850adc..0c1bd21 100644 --- a/crates/testbed/repositories-ci.yaml +++ b/crates/testbed/repositories-ci.yaml @@ -7,10 +7,10 @@ fim: suffix: model: bigcode/starcoder request_params: - max_new_tokens: 150 + maxNewTokens: 150 temperature: 0.2 - do_sample: true - top_p: 0.95 + doSample: true + topP: 0.95 tls_skip_verify_insecure: false tokenizer_config: repository: bigcode/starcoder diff --git a/crates/testbed/repositories.yaml b/crates/testbed/repositories.yaml index f856871..4418993 100644 --- a/crates/testbed/repositories.yaml +++ b/crates/testbed/repositories.yaml @@ -7,10 +7,10 @@ fim: suffix: model: bigcode/starcoder request_params: - max_new_tokens: 150 + maxNewTokens: 150 temperature: 0.2 - do_sample: true - top_p: 0.95 + doSample: true + topP: 0.95 tls_skip_verify_insecure: false tokenizer_config: repository: bigcode/starcoder diff --git a/crates/testbed/src/types.rs b/crates/testbed/src/types.rs index e5ccb42..c75da6d 100644 --- a/crates/testbed/src/types.rs +++ b/crates/testbed/src/types.rs @@ -14,6 +14,7 @@ impl Request for GetCompletions { } #[derive(Clone, Debug, Deserialize, Serialize)] +#[serde(rename_all = "camelCase")] pub(crate) struct RequestParams { pub(crate) max_new_tokens: u32, pub(crate) temperature: f32, @@ -60,6 +61,7 @@ pub(crate) enum TokenizerConfig { } #[derive(Clone, Debug, Deserialize, Serialize)] +#[serde(rename_all = "camelCase")] pub(crate) struct GetCompletionsParams { #[serde(flatten)] pub(crate) text_document_position: TextDocumentPositionParams,