gered/ggdt
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

this should be a mutable reference argument

Browse source 
to be honest, i'm not sure how this compiled successfully before, since
the value being passed in via Bitmap::triangle_2d_custom is clearly of
type `&mut PixelType` ... ? either way, this is now written consistently
and we get to remove an unnecessary unsafe block
This commit is contained in:
Gered 2023-03-31 22:16:32 -04:00
parent 4fcb6a9f0f
commit 69bb0c4830
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ggdt/src/graphics/bitmap/triangles.rs
View file

@ -13,7 +13,7 @@ impl<PixelType: Pixel> Bitmap<PixelType> {
a, // a, //
b, b,
c, c,
|dest_pixels, _w0, _w1, _w2| unsafe { |dest_pixels, _w0, _w1, _w2| {
*dest_pixels = color; *dest_pixels = color;
}, },
) )
@ -25,7 +25,7 @@ impl<PixelType: Pixel> Bitmap<PixelType> {
a: Vector2, a: Vector2,
b: Vector2, b: Vector2,
c: Vector2, c: Vector2,
pixel_fn: impl Fn(*mut PixelType, f32, f32, f32), pixel_fn: impl Fn(&mut PixelType, f32, f32, f32),
) { ) {
// based off the triangle rasterization algorithm presented in these article series' (as well as others) // based off the triangle rasterization algorithm presented in these article series' (as well as others)
// https://fgiesen.wordpress.com/2013/02/17/optimizing-sw-occlusion-culling-index/ // https://fgiesen.wordpress.com/2013/02/17/optimizing-sw-occlusion-culling-index/