From cd5d0f3c8a75dd78f06fb04873aee8d1a1528113 Mon Sep 17 00:00:00 2001
From: gered <gered@blarg.ca>
Date: Sat, 6 Mar 2021 19:55:58 -0500
Subject: [PATCH] minor cleanup

---
 src/gxfb.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/gxfb.c b/src/gxfb.c
index e78d3f3..0a7a53d 100644
--- a/src/gxfb.c
+++ b/src/gxfb.c
@@ -123,6 +123,13 @@ static void gx_init_projection(GXRModeObj *rmode) {
 	GX_LoadProjectionMtx(perspective, GX_ORTHOGRAPHIC);
 }
 
+static void gx_init_modelview(void) {
+	// set up constant modelview matrix for rending our quad with
+	guMtxIdentity(modelview);
+	guMtxTransApply(modelview, modelview, 0.0, 0.0, -5.0);
+	GX_LoadPosMtxImm(modelview, GX_PNMTX0);
+}
+
 static void copy_framebuffer_to_texture(void) {
 	// gamecube/wii texture memory is organized in 32-byte tiles. for 32-bit ARGB-format textures, as we are using,
 	// this means the 32-bit space comprises a 4x4 tile. so we need to copy our contiguous 2d source framebuffer
@@ -226,6 +233,7 @@ int fb_init(GXRModeObj *rmode, int width, int height) {
 	gx_init_texture(width, height);
 	gx_init_vertex_format();
 	gx_init_projection(rmode);
+	gx_init_modelview();
 
 	// allocate application-accessible framebuffer. ARGB-format pixels
 	framebuffer_size = width * height * 4;
@@ -243,11 +251,6 @@ int fb_init(GXRModeObj *rmode, int width, int height) {
 	quad_x_offset = ((rmode->fbWidth / 2) - width) / 2;
 	quad_y_offset = ((rmode->efbHeight) - height) / 2;
 
-	// set up constant modelview matrix for rending our quad with
-	guMtxIdentity(modelview);
-	guMtxTransApply(modelview, modelview, 0.0, 0.0, -5.0);
-	GX_LoadPosMtxImm(modelview, GX_PNMTX0);
-
 	return 0;
 }