Jtwig Integration #2

New issue

Closed

opened 2014-11-29 23:08:51 -05:00 by joao-de-melo · 1 comment

joao-de-melo commented

2014-11-29 23:08:51 -05:00

(Migrated from github.com)

Hi @gered,

as this is a nice Jtwig integration, I'd like to propose you to move this integration to the jtwig umbrella (http://github.com/jtwig) and became an official committer.

Hi @gered, as this is a nice Jtwig integration, I'd like to propose you to move this integration to the jtwig umbrella (http://github.com/jtwig) and became an official committer.

gered commented

2014-12-01 12:13:31 -05:00

(Migrated from github.com)

Hey,

Actually I've kind of moved on from this project unfortunately. :( You may have suspected as much with the last commit being some 6 months ago.

I had a lot of problems updating this to Jtwig 3.x while keeping a mostly idiomatic Clojure API. The main source of problems seemed to stem from the use of annotations everywhere for extension points (functions) as well as certain bits I thought I would need to override in Jtwig itself to work with how I wanted clj-jtwig to work (various class fields / methods being marked private vs protected, etc. making it impossible for me to subclass stuff to provide the functionality I needed). I thought about submitting a PR with some changes that would assist me in this, but realized a number of these changes would not be useful at all in Jtwig and would only benefit me. As of right now, clj-jtwig is stuck at Jtwig 2.x.

At the same time, my prior need for a general-purpose templating library has kind of gone away as I find myself working more and more with single page web apps using ClojureScript (Om/Reagent) which doesn't really make a whole lot of use of server-side templating. So this project has now dropped off my to-do list mostly.

Anyway, thanks for asking, but I think I'll decline. That said, if anyone in the future ever wants to take over this project I would gladly transfer ownership over to them.

-Gered

Hey, Actually I've kind of moved on from this project unfortunately. :( You may have suspected as much with the last commit being some 6 months ago. I had a lot of problems updating this to Jtwig 3.x while keeping a mostly idiomatic Clojure API. The main source of problems seemed to stem from the use of annotations everywhere for extension points (functions) as well as certain bits I thought I would need to override in Jtwig itself to work with how I wanted clj-jtwig to work (various class fields / methods being marked private vs protected, etc. making it impossible for me to subclass stuff to provide the functionality I needed). I thought about submitting a PR with some changes that would assist me in this, but realized a number of these changes would not be useful at all in Jtwig and would _only_ benefit me. As of right now, clj-jtwig is stuck at Jtwig 2.x. At the same time, my prior need for a general-purpose templating library has kind of gone away as I find myself working more and more with single page web apps using ClojureScript (Om/Reagent) which doesn't really make a whole lot of use of server-side templating. So this project has now dropped off my to-do list mostly. Anyway, thanks for asking, but I think I'll decline. That said, if anyone in the future ever wants to take over this project I would gladly transfer ownership over to them. -Gered

This repo is archived. You cannot comment on issues.