gered/aging-session
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

allow sweeper-thread sweeping threshold to be disabled and always run

Browse source 
if a number is not provided, then every time the sweeper thread body
executes, it will try to sweep the entire session, even if nothing
has read/written the session store in the mean time. this is also now
the default behaviour. the thinking here is that this allows for the
best real-time-feeling behaviour with regards to session expiry,
especially for low-traffic / low-activity web apps. applications
that care more about performance, can easily set a threshold here and
get the old behaviour back.
This commit is contained in:
Gered 2022-01-02 18:27:52 -05:00
parent 71ba250f61
commit 4b0ddab2ea
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/aging_session/memory.clj
View file

@ -73,7 +73,8 @@
(write-session [_ key data] (write-session [_ key data]
(let [key (or key (unique-id))] (let [key (or key (unique-id))]
(swap! op-counter inc) (if op-threshold
(swap! op-counter inc))
(if refresh-on-write (if refresh-on-write
(swap! session-map assoc key (new-entry data)) (swap! session-map assoc key (new-entry data))
(swap! session-map write-entry key data)) (swap! session-map write-entry key data))
@ -87,9 +88,10 @@
"Sweeper thread that watches the session and cleans it." "Sweeper thread that watches the session and cleans it."
[{:keys [ttl op-counter op-threshold session-map]} sweep-interval] [{:keys [ttl op-counter op-threshold session-map]} sweep-interval]
(loop [] (loop []
(if op-threshold
(when (>= @op-counter op-threshold) (when (>= @op-counter op-threshold)
(swap! session-map sweep-session ttl) (swap! session-map sweep-session ttl)
(reset! op-counter 0)) (reset! op-counter 0)))
(Thread/sleep sweep-interval) (Thread/sleep sweep-interval)
(recur))) (recur)))
@ -105,14 +107,14 @@
:or {session-atom (atom {}) :or {session-atom (atom {})
refresh-on-write true refresh-on-write true
refresh-on-read true refresh-on-read true
sweep-threshold 200 sweep-threshold nil
sweep-interval 30}} opts sweep-interval 30}} opts
; internally, we want time values as milliseconds. externally, it is more convenient to have them specified ; internally, we want time values as milliseconds. externally, it is more convenient to have them specified
; as seconds because, really, for sessions, no one is really going to want to specify sub-second values for ; as seconds because, really, for sessions, no one is really going to want to specify sub-second values for
; any of these times! (no, you don't really need a sweeper thread running multiple times per second ...) ; any of these times! (no, you don't really need a sweeper thread running multiple times per second ...)
sweep-interval (* 1000 sweep-interval) sweep-interval (* 1000 sweep-interval)
ttl (* 1000 ttl) ttl (* 1000 ttl)
op-counter (atom 0) op-counter (if sweep-threshold (atom 0))
store (MemoryAgingStore. session-atom ttl refresh-on-write refresh-on-read op-counter sweep-threshold)] store (MemoryAgingStore. session-atom ttl refresh-on-write refresh-on-read op-counter sweep-threshold)]
(in-thread #(sweeper-thread store sweep-interval)) (in-thread #(sweeper-thread store sweep-interval))
store)) store))