gered/aging-session
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

minor performance enhancements to read-session and write-session

Browse source
This commit is contained in:
Gered 2022-01-03 17:26:32 -05:00
parent c40c663bde
commit 334bb6b353
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/aging_session/core.clj
View file

@ -52,7 +52,7 @@
(let [session-map (sweep-entry session-map ttl key)] (let [session-map (sweep-entry session-map ttl key)]
(if (and refresh-on-read? (if (and refresh-on-read?
(contains? session-map key)) (contains? session-map key))
(assoc-in session-map [key :timestamp] (now)) (update session-map key assoc :timestamp (now)) ; note: performs faster than assoc-in
session-map))) session-map)))
(defn- process-write-entry (defn- process-write-entry
@ -64,7 +64,7 @@
; when not refreshing-on-write, we only need to update the entry value if there is an existing entry. otherwise, ; when not refreshing-on-write, we only need to update the entry value if there is an existing entry. otherwise,
; it is of course a brand new entry ; it is of course a brand new entry
(if (contains? session-map key) (if (contains? session-map key)
(assoc-in session-map [key :value] data) (update session-map key assoc :value data) ; note: performs faster than assoc-in
(assoc session-map key (new-entry data))))) (assoc session-map key (new-entry data)))))
(defprotocol AgingStore (defprotocol AgingStore
@ -87,7 +87,9 @@
(when (contains? @session-atom key) (when (contains? @session-atom key)
(let [session-map (swap! session-atom process-read-entry ttl key refresh-on-read)] (let [session-map (swap! session-atom process-read-entry ttl key refresh-on-read)]
(if (contains? session-map key) (if (contains? session-map key)
(get-in session-map [key :value]) (-> session-map ; note: performs faster than get-in
(get key)
(get :value))
; TODO: notify expiry listener about expired 'key' here ; TODO: notify expiry listener about expired 'key' here
)))) ))))