gered/PortableGL
Archived
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

remove StringBuilder length doubling

Browse source 
This was added from looking at what OpenTK was doing for it's similar
helper methods, but the length doubling was apparently to work around a
Mono 1.9.1 bug which seems to have been fixed (? works fine for me now?)
This commit is contained in:
Gered 2013-08-11 18:48:32 -04:00
parent 75724d9139
commit dc5124da0f
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
PortableGL/GL20Helpers.cs
View file

@ -222,7 +222,7 @@ namespace PortableGL
{ {
int length = 0; int length = 0;
glGetProgramiv(program, GL_ACTIVE_ATTRIBUTE_MAX_LENGTH, ref length); glGetProgramiv(program, GL_ACTIVE_ATTRIBUTE_MAX_LENGTH, ref length);
StringBuilder sb = new StringBuilder(length == 0 ? 1 : length * 2); StringBuilder sb = new StringBuilder(length == 0 ? 1 : length);
glGetActiveAttrib(program, index, sb.Capacity, out length, out size, out type, sb); glGetActiveAttrib(program, index, sb.Capacity, out length, out size, out type, sb);
return sb.ToString(); return sb.ToString();
} }
@ -244,7 +244,7 @@ namespace PortableGL
{ {
int length = 0; int length = 0;
glGetProgramiv(program, GL_ACTIVE_UNIFORM_MAX_LENGTH, ref length); glGetProgramiv(program, GL_ACTIVE_UNIFORM_MAX_LENGTH, ref length);
StringBuilder sb = new StringBuilder(length == 0 ? 1 : length * 2); StringBuilder sb = new StringBuilder(length == 0 ? 1 : length);
glGetActiveUniform(program, index, sb.Capacity, out length, out size, out type, sb); glGetActiveUniform(program, index, sb.Capacity, out length, out size, out type, sb);
return sb.ToString(); return sb.ToString();
} }
@ -290,7 +290,7 @@ namespace PortableGL
glGetProgramiv(program, GL_INFO_LOG_LENGTH, ref length); glGetProgramiv(program, GL_INFO_LOG_LENGTH, ref length);
if (length == 0) if (length == 0)
return String.Empty; return String.Empty;
StringBuilder sb = new StringBuilder(length * 2); StringBuilder sb = new StringBuilder(length);
glGetProgramInfoLog(program, sb.Capacity, out length, sb); glGetProgramInfoLog(program, sb.Capacity, out length, sb);
return sb.ToString(); return sb.ToString();
} }
@ -334,7 +334,7 @@ namespace PortableGL
glGetShaderiv(shader, GL_INFO_LOG_LENGTH, ref length); glGetShaderiv(shader, GL_INFO_LOG_LENGTH, ref length);
if (length == 0) if (length == 0)
return String.Empty; return String.Empty;
StringBuilder sb = new StringBuilder(length * 2); StringBuilder sb = new StringBuilder(length);
glGetShaderInfoLog(shader, sb.Capacity, out length, sb); glGetShaderInfoLog(shader, sb.Capacity, out length, sb);
return sb.ToString(); return sb.ToString();
} }
@ -364,7 +364,7 @@ namespace PortableGL
glGetShaderiv(shader, GL_SHADER_SOURCE_LENGTH, ref length); glGetShaderiv(shader, GL_SHADER_SOURCE_LENGTH, ref length);
if (length == 0) if (length == 0)
return String.Empty; return String.Empty;
StringBuilder sb = new StringBuilder(length * 2); StringBuilder sb = new StringBuilder(length);
glGetShaderSource(shader, sb.Capacity, out length, sb); glGetShaderSource(shader, sb.Capacity, out length, sb);
return sb.ToString(); return sb.ToString();
} }