Get and display world record from speedrun.com #24

Merged

4ilo merged 4 commits from master into master 2018-06-20 18:42:27 -04:00

Conversation 4 Commits 4 Files changed 13 +667 -3

4ilo commented 2018-02-18 08:48:09 -05:00 (Migrated from github.com)

Copy link

• New global setting to toggle display of world record
  

• Display record in the run footer
  

• Add the world record info from speedrun.com per run/save file
  

• Dialog for easy searching and selection from the speedrun.com api
  

- New global setting to toggle display of world record  - Display record in the run footer  - Add the world record info from speedrun.com per run/save file  - Dialog for easy searching and selection from the speedrun.com api 

👍 1

gered commented 2018-02-18 14:43:45 -05:00 (Migrated from github.com)

Copy link

This looks great! 👍 Thanks for the contribution.

I'll review it a bit more either later today or tomorrow before merging it, and will package it up as a new release (v1.5.5) if I don't run into any issues.

This looks great! :+1: Thanks for the contribution. I'll review it a bit more either later today or tomorrow before merging it, and will package it up as a new release (v1.5.5) if I don't run into any issues.

4ilo commented 2018-02-18 14:47:45 -05:00 (Migrated from github.com)

Copy link

If you encounter any issues or problems, feel free to give me some feedback and i will try to fix them.

If you encounter any issues or problems, feel free to give me some feedback and i will try to fix them.

gered commented 2018-06-20 18:43:16 -04:00 (Migrated from github.com)

Copy link

Four months late! :'( I'm very sorry! Thanks for your efforts with this, it looks great to me. I'll package up a new release with this right now.

Four months late! :'( I'm very sorry! Thanks for your efforts with this, it looks great to me. I'll package up a new release with this right now.

gered commented 2018-06-20 19:32:11 -04:00 (Migrated from github.com)

Copy link

Hrmm, actually I'll hold off on packaging a new release for now. I just ran into some issues with the search appearing to freeze (searching for "zelda" but any other search results in the same behaviour... which is strange as it worked fine for me 20 minutes ago... maybe network related, will investigate more shortly).

EDIT: Nevermind, an error dialog was popping up saying "Could not connect to speedrun.com" (via showError()), but for some reason it was popping up behind the "World Record selection" dialog, so I never saw it and just assumed the app had frozen while waiting for a network response or similar. Anyway, I'll see about tweaking the error dialog so it doesn't show up behind like this.

Hrmm, actually I'll hold off on packaging a new release for now. I just ran into some issues with the search appearing to freeze (searching for "zelda" but any other search results in the same behaviour... which is strange as it worked fine for me 20 minutes ago... maybe network related, will investigate more shortly). **EDIT**: Nevermind, an error dialog was popping up saying "Could not connect to speedrun.com" (via `showError()`), but for some reason it was popping up _behind_ the "World Record selection" dialog, so I never saw it and just assumed the app had frozen while waiting for a network response or similar. Anyway, I'll see about tweaking the error dialog so it doesn't show up behind like this.

👍 1

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels   

bug

  

duplicate

  

enhancement

  

help wanted

  

invalid

  

question

  

wontfix

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gered/Llanfair#24

No description provided.