gered/Blarg.GameFramework
Archived
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

change the way RemainingElements calculates and remove safety from MoveNext/Previous

Browse source 
This is mainly to fix a problem where it's not exactly intuitive to code
a loop which runs through a buffer using MoveNext() up until the end of
RemainingElements. When the loop ends, you'd expect to be able to take
that same buffer, Extend() it, and be able to immediately start running
through it again without calling MoveNext() one extra time inbetween
both loops. This fix makes it so this kind of "intuitive" usage pattern
works, at the expense of no automatic bounds safety with CurrentPosition
This commit is contained in:
Gered 2013-08-27 22:10:03 -04:00
parent 5a37b8bdfe
commit 55f697ae6c
2 changed files with 2 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Blarg.GameFramework/Graphics/IndexBuffer.cs
View file

@ -10,7 +10,7 @@ namespace Blarg.GameFramework.Graphics
public int RemainingElements
{
get { return (NumElements - 1) - CurrentPosition; }
get { return NumElements - CurrentPosition; }
}
public override int NumElements
@ -91,10 +91,7 @@ namespace Blarg.GameFramework.Graphics
{
++CurrentPosition;
if (CurrentPosition >= NumElements)
{
--CurrentPosition;
return false;
}
else
return true;
}
@ -104,10 +101,7 @@ namespace Blarg.GameFramework.Graphics
if (CurrentPosition == 0)
return false;
else
{
--CurrentPosition;
return true;
}
}
public void Move(int amount)

8
Blarg.GameFramework/Graphics/VertexBuffer.cs
View file

@ -20,7 +20,7 @@ namespace Blarg.GameFramework.Graphics
public int RemainingElements
{
get { return (NumElements - 1) - CurrentPosition; }
get { return NumElements - CurrentPosition; }
}
public override int NumElements
@ -143,10 +143,7 @@ namespace Blarg.GameFramework.Graphics
{
++CurrentPosition;
if (CurrentPosition >= NumElements)
{
--CurrentPosition;
return false;
}
else
return true;
}
@ -156,10 +153,7 @@ namespace Blarg.GameFramework.Graphics
if (CurrentPosition == 0)
return false;
else
{
--CurrentPosition;
return true;
}
}
public void Move(int amount)